Custom schedule calendar event rendering #10294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customize the styling depending on the length of the event, rather than relying on full calendar to do everything. Made 10min font size smaller, and adjusted line heights and how many lines to use for other lengths. One size effect is that the time text is slightly bigger now, which seems good/fine to me.
If/when this is merged, it will be easy to implement a tool-tip on the events, so that people can hover/tap on events to see the full time/title/etc. if the box happens to be too small. (We didn't do this originally because we didn't want to do custom event rendering just to get a tool-tip; but now it's worth it.) The changes can also be applied to the edit schedule view (it would be nice to be able to read 10 minute events when creating a schedule, especially since a tutorial is often that long). And on a related note, it would be good for mobile view to use a separate calendar per day, so that the days can stack on top of each other instead of squishing way too much.
Before:
After:
Examples of all event lengths:
