Set architectures property to avr #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This library is AVR specific so the previous wildcard value of the architectures property in library.properties is incorrect. This change will cause this library's examples to appear under the File > Examples > INCOMPATIBLE > EEPROMex menu when a non-avr board is selected, which can provide a valuable clue to the user why the library isn't working with that board. The Arduino IDE also provides a library mismatch warning but unfortunately this does not currently appear when compilation fails due to an included file not being found, which is the outcome of attempting to compile for a non-AVR board. This issue will hopefully be resolved in a future version of the Arduino IDE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is AVR specific so the previous wildcard value of the
architecturesproperty in library.properties is incorrect.This change will cause this library's examples to appear under the File > Examples > INCOMPATIBLE > EEPROMex menu when a non-AVR board is selected, which can provide a valuable clue to the user why the library isn't working with that board (e.g. #19). The Arduino IDE also provides a library mismatch warning but unfortunately this does not currently appear when compilation fails due to an included file not being found (arduino/arduino-builder#228), which is the outcome of attempting to compile this library for a non-AVR board. This issue will hopefully be resolved in a future version of the Arduino IDE.