Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

develop serverside nodes #26

Merged
merged 25 commits into from
Feb 17, 2024
Merged

Conversation

hidetak
Copy link
Contributor

@hidetak hidetak commented Feb 6, 2024

This is an implementation of the server-side node described in the following Issue.
#25

The following modifications are also implemented for the client side.

  • modified to use node-wot 0.8.10
  • read property node execution is now triggered by input
  • Wait until the observe property and subscribe event execution succeeds

@egekorkan
Copy link
Member

egekorkan commented Feb 16, 2024

We discussed this in the call and @egekorkan will try using them on his computer. Then we can merge it and then move to the Eclipse Thingweb.

The issues in node-wot are:

We can merge this PR without fixing those first.

@danielpeintner
Copy link
Contributor

  • modified to use node-wot 0.8.10

Minor: there is already node-wot v0.8.12 out. Updating to it shouldn't cause any issue since there are no API changes or such. Thanks!

Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes but overall, it is working. I just didn't manage to get the property on the server side working. I have just put the following in the function attached to the property:

image

@hidetak how can I make it work? I get an empty payload when I read the property.

Overall, thank you many times for doing this work! You even have Japanese UI elements that will make Thingweb project international ;)

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@hidetak
Copy link
Contributor Author

hidetak commented Feb 16, 2024

@danielpeintner

Thank you for your comment.
I have changed the version of node-wot to 0.8.12.

@hidetak
Copy link
Contributor Author

hidetak commented Feb 16, 2024

@egekorkan

Thank you for your confirmation.

image

The input of a Server-Property node is done when there is a change to that property on the server side. At this time, it is not necessary to input the changed value.

The value returned to the client must be obtained by a flow connected to the first output of the Server-Property node and input to the Server-End node.

The value of the write is output from the second output of the Server-Property node, so the connected flow should process that value and the end should connect the Server-End node.

If you have any other questions, please feel free to ask.

Overall, thank you many times for doing this work! You even have Japanese UI elements that will make Thingweb project international ;)

I am glad to hear you say so.
I hope to take the next step to internationalize the client side as well.
If there are any odd English words, I would appreciate it if you could point them out to me.

@egekorkan
Copy link
Member

@hidetak I have done the same thing once again and it worked, so I am sorry for the first comment about readproperty. I will now check the english and make commits if I see issues. If not, we can merge it and move to its new place

@egekorkan
Copy link
Member

I made some small changes and it is looking good. Merging.

When moving to Eclipse, I will try to follow https://www.johno.com/move-directory-between-repos-with-git-history so that the contributors are credited correctly. I hope it works otherwise it would look as if I did all the work.

@hidetak
Copy link
Contributor Author

hidetak commented Feb 17, 2024

@egekorkan

I made some small changes and it is looking good. Merging.

Thank you for the correction and merge.

@egekorkan egekorkan merged commit fd49084 into thingweb:master Feb 17, 2024
@egekorkan
Copy link
Member

In the end, I have used the instructions at https://gist.github.com/trongthanh/2779392

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants