-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
merge wot serverside nodes
little changes for publish to npmjs
We discussed this in the call and @egekorkan will try using them on his computer. Then we can merge it and then move to the Eclipse Thingweb. The issues in node-wot are:
We can merge this PR without fixing those first. |
Minor: there is already node-wot v0.8.12 out. Updating to it shouldn't cause any issue since there are no API changes or such. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes but overall, it is working. I just didn't manage to get the property on the server side working. I have just put the following in the function attached to the property:
@hidetak how can I make it work? I get an empty payload when I read the property.
Overall, thank you many times for doing this work! You even have Japanese UI elements that will make Thingweb project international ;)
Thank you for your comment. |
@hidetak I have done the same thing once again and it worked, so I am sorry for the first comment about readproperty. I will now check the english and make commits if I see issues. If not, we can merge it and move to its new place |
I made some small changes and it is looking good. Merging. When moving to Eclipse, I will try to follow https://www.johno.com/move-directory-between-repos-with-git-history so that the contributors are credited correctly. I hope it works otherwise it would look as if I did all the work. |
Thank you for the correction and merge. |
In the end, I have used the instructions at https://gist.github.com/trongthanh/2779392 |
This is an implementation of the server-side node described in the following Issue.
#25
The following modifications are also implemented for the client side.