Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement funk.Partition #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions partition.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package funk

import (
"reflect"
)

// Partition separates the elements of the input array into two slices based on the predicate function.
// It takes an array-like data structure and a predicate function that determines the Partition.
// The predicate function should have the signature func(elementType) bool.
// The function returns two new slices: one containing elements that satisfy the predicate,
// and the other containing elements that do not satisfy the predicate.
func Partition(in, predicate interface{}) interface{} {
if !IsCollection(in) {
panic("First parameter must be a collection")
}

if !IsFunction(predicate, 1, 1) {
panic("Second argument must be function")
}

inValue, funcValue := reflect.ValueOf(in), reflect.ValueOf(predicate)

funcType := funcValue.Type()

if funcType.Out(0).Kind() != reflect.Bool {
panic("Return argument should be a boolean")
}

result := reflect.MakeSlice(reflect.SliceOf(reflect.TypeOf(in)), 0, 0)
partitionOne, partitionTwo := reflect.MakeSlice(inValue.Type(), 0, 0), reflect.MakeSlice(inValue.Type(), 0, 0)

for i := 0; i < inValue.Len(); i++ {
element := inValue.Index(i)

res := funcValue.Call([]reflect.Value{reflect.ValueOf(element.Interface())})
if res[0].Interface().(bool) {
partitionOne = reflect.Append(partitionOne, element)
} else {
partitionTwo = reflect.Append(partitionTwo, element)
}
}

if partitionOne.Len() > 0 || partitionTwo.Len() > 0 {
result = reflect.Append(result, partitionOne, partitionTwo)
}

return result.Interface()
}
52 changes: 52 additions & 0 deletions partition_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
package funk

import (
"testing"

"github.com/stretchr/testify/assert"
)

func Test_partition_valid_int(t *testing.T) {
result := Partition([]int{1, 2, 3, 4}, func(n int) bool {
return n%2 == 0
})

assert.Equal(t, [][]int{{2, 4}, {1, 3}}, result)
}

func Test_partition_valid_float64(t *testing.T) {
result := Partition([]float64{1.1, 2.2, 3.3, 4.4}, func(n float64) bool {
return n > float64(2)
})

assert.Equal(t, [][]float64{{2.2, 3.3, 4.4}, {1.1}}, result)
}

func Test_partition_valid_string(t *testing.T) {
result := Partition([]string{"a", "b", "c"}, func(n string) bool {
return n > "a"
})

assert.Equal(t, [][]string{{"b", "c"}, {"a"}}, result)
}

func Test_partition_valid_struct(t *testing.T) {
result := Partition([]*Foo{
{
FirstName: "Kakalot",
Age: 26,
},
{
FirstName: "Vegeta",
Age: 27,
},
{
FirstName: "Trunk",
Age: 10,
},
}, func(n *Foo) bool {
return n.Age%2 == 0
})

assert.Equal(t, [][]*Foo{{{FirstName: "Kakalot", Age: 26}, {FirstName: "Trunk", Age: 10}}, {{FirstName: "Vegeta", Age: 27}}}, result)
}