Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problem in table controller #2598

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anthony0030
Copy link

If there was any tag inside the link to edit or delete like a strong tag or an icon tag, the link would not take you to the correct page.

@nickcharlton
Copy link
Member

I think it'd be a good idea to add a test around this, so that we don't break it in future. Is that something you could do?

@anthony0030
Copy link
Author

@nickcharlton I took a look and could not find any test file for table_controller. Please point me in the right direction, to be able to see if I am able to add some tests in.

@excid3, is this something that would be easy for you to do?

@nickcharlton
Copy link
Member

It's possible we just don't have any at all. A good starting point might be one of the feature specs, if there's one that fits this functionality best.

@anthony0030
Copy link
Author

I looked into writing a test for this. I have never written tests in this format. At this time I won't be able to assist further.

@nickcharlton nickcharlton added the open-summit topics we're considering for open summit label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-summit topics we're considering for open summit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants