use Strong Parameters on User model user_params method #979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests 2 small improvements:
UsersController
user_params
method (even if empty)this way we can easily override
user_params
method to add new custom fields for User modellet me know if it makes sense to add a configuration entry for changing default new User parameters, for example:
as default:
Clearance.configuration.permit_user_parameters = [:email, :password]
we could customize it:
Clearance.configuration.permit_user_parameters = [:name, :email, :password]
and default permit call would looks like:
params.fetch(Clearance.configuration.user_parameter, {}).permit(*Clearance.configuration.permit_user_parameters)