Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite #92

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Vite #92

wants to merge 12 commits into from

Conversation

bakerkretzmar
Copy link
Contributor

This PR is a proof of concept for using Vite to build Jigsaw sites 🔥 it's very fast, reloads your site when stuff changes, and handles building your assets and Jigsaw site in both dev and production.

Note:

  • This isn't directly related to the blog template, but I wanted to us a real site with some content and assets for testing. Most of the actual code here, particular the contents of vite.config.js and the vite() PHP function, can be moved into a package or Jigsaw core once this is more robust.
  • This could probably be a lot cleaner if we moved some project directories around, I intentionally tried not to do that here but some of the config might be simpler or unnecessary if, for example, we kept bundled assets and completely static assets in different folders, maybe outside of source.
  • The import.meta.env.BASE_URL thing in Search.vue is killing me, but that was the only way I could get Vite and my browser to properly load that image both in development and in a real build, everything else worked in one but not the other.

@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for jigsaw-blog-template-demo failed.

Name Link
🔨 Latest commit 291dd33
🔍 Latest deploy log https://app.netlify.com/sites/jigsaw-blog-template-demo/deploys/649f4f0b3b638d0008843c58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant