ffmpeg export #2309
Draft
ffmpeg export #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a functional usage example of the Subprocess class is currently at src/engine/wavOps.cpp:124 (sorry, it's misplaced)
|
I'm kind of second-guessing this because I noticed |
Oh my fucking god this was so goddamn hard to implement. But it's here. I don't know how I was so lucky but I came across this: https://stackoverflow.com/questions/53734902/why-child-process-is-waiting-while-using-fork-and-pipes-for-stdin-from-parents which made me realize stuff can go bad if I do not close the file descriptors at every possible moment. In this case, I had to close as many unrelated ends of stdinPipe as possible so the subprocess could figure out the export was finished
who knew IPC could be so hard
This was a nightmare :) I did learn how poll() works though. That's nice. But I had to go through so much to find that out lol... an entire afternoon.
the feature is still not implemented, but at least now it compiles with a message saying it's not yet supported
it does on mingw though
|
The problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at supporting custom format export via ffmpeg, using the fact that this command works:
The idea then is to open a
ffmpegchild process and write the export data (which would be written to a.wavfile) to it, without needing to link against ffmpeg's libraries. And it effectively makes it optional!Progress:
ffmpegis in PATHscriptingbranch)