Skip to content

Commit

Permalink
chore(infra): Default to building ARM only [experiment]
Browse files Browse the repository at this point in the history
  • Loading branch information
Justinon committed Sep 11, 2023
1 parent eb50b33 commit 213d19b
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 76 deletions.
8 changes: 4 additions & 4 deletions src/workflows/ecs-service-build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export module ecsServiceBuildPublishWorkflow {
export interface BuildPublishOptionsConfig extends OptionalNodeVersion {
/**
* List of build architectures for which to build Docker artifacts.
* @default all
* @default ARM64
*/
readonly buildArchitectures?: ClickUpSupportedArchType[];
}
Expand All @@ -92,7 +92,7 @@ export module ecsServiceBuildPublishWorkflow {
) {
let jobs: Record<string, any> = {};
const supportedArchTypes = Object.values(ClickUpSupportedArchType);
const buildArchitectures = options.buildArchitectures ?? supportedArchTypes;
const buildArchitectures = options.buildArchitectures ?? [ClickUpSupportedArchType.ARM64];

if (buildArchitectures.length === 0) {
throw new Error(
Expand Down Expand Up @@ -219,7 +219,7 @@ export module ecsServiceBuildPublishWorkflow {
'buildcache-aws-secret-access-key': '${{ secrets.ECR_BUILD_CACHE_AWS_SECRET_ACCESS_KEY }}',
'buildcache-aws-region': '${{ secrets.ECR_BUILD_CACHE_AWS_REGION }}',
'buildcache-ecr-repo-name': 'monorepo-buildcache',
'buildcache-pull-tag': '${{ env.DOCKER_TAG_DRAFT_COMMIT }}-amd64', // FIXME:
'buildcache-pull-tag': '${{ env.DOCKER_TAG_DRAFT_COMMIT }}-arm64', // FIXME:
'lacework-account-name': '${{ secrets.LW_ACCOUNT_NAME }}',
'lacework-access-token': '${{ secrets.LW_ACCESS_TOKEN }}',
},
Expand Down Expand Up @@ -255,7 +255,7 @@ export module ecsServiceBuildPublishWorkflow {
id: 'buildcache-pull',
with: {
'docker-repo-uri': '${{ steps.buildcache.outputs.docker-repo-uri }}',
'pull-tag': '${{ env.DOCKER_TAG_DRAFT_COMMIT }}-amd64', // FIXME: amd64 hardcoded!
'pull-tag': '${{ env.DOCKER_TAG_DRAFT_COMMIT }}-arm64', // FIXME: amd64 hardcoded!
},
},
{
Expand Down
1 change: 1 addition & 0 deletions src/workflows/ecs-service-cd.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export module ecsServiceCDWorkflow {
Deploy: {
uses: `./${ecsServiceDeployWorkflow.WORKFLOW_LOCATION}`,
needs: ['get-version'],
secrets: 'inherit',
with: {
'service-name': project.serviceName,
version: '${{ needs.get-version.outputs.version }}',
Expand Down
80 changes: 8 additions & 72 deletions test/__snapshots__/clickup-ecs-service.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 213d19b

Please sign in to comment.