Skip to content

Commit

Permalink
Merge branch 'main' into sourcemap-fix
Browse files Browse the repository at this point in the history
  • Loading branch information
ahammond authored Oct 12, 2023
2 parents 7a77813 + 2cf026a commit 7ec6793
Show file tree
Hide file tree
Showing 10 changed files with 62 additions and 51 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/semgrep.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/cdk-context-json/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ index aa0d831..d4b75b6 100644
+
+ // cdk.context.json lookup support role
+ const cdkPipelinesVa = core.Environment.usCdkPipelines('us-east-1');
+ const vaStageId = cdkPipeline.getUniqueStageIdentifier(cdkPipelinesVa).addPrefix(['oicd']);
+ const vaStageId = cdkPipeline.getUniqueStageIdentifier(cdkPipelinesVa).addPrefix(['oidc']);
+ oidcPermissions.addStage(
+ GitHubActionsOIDCCdkContextLookupRole.asStage(this, vaStageId.pascal, {...commonProps, namedEnv: cdkPipelinesVa})
+ )
Expand Down
2 changes: 1 addition & 1 deletion docs/cdk-diff/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ This is to make sure you OIDC stages don't conflict with your service.
+ const oidcPermissions = githubPipeline.addWave('OIDC-GitHub-Actions-Permissions');
+ [core.Environment.usQa, core.Environment.globalProd].forEach((factory) => {
+ const namedEnv = factory('us-east-1');
+ const stageId = cdkPipeline.getUniqueStageIdentifier(namedEnv).addPrefix(['oicd']);
+ const stageId = cdkPipeline.getUniqueStageIdentifier(namedEnv).addPrefix(['oidc']);
+ oidcPermissions.addStage(
+ GitHubActionsOIDCPermissions.asStage(this, stageId.pascal, { ...commonProps, namedEnv }),
+ );
Expand Down
6 changes: 3 additions & 3 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/datadog-service-catalog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ export module datadogServiceCatalog {
name: `Publish DD Service Catalog for ${serviceName}`,
uses: 'arcxp/datadog-service-catalog-metadata-provider@v2',
with: {
'service-version': `${DefaultServiceCatalogValues.SERVICE_VERSION}`,
'schema-version': `${DefaultServiceCatalogValues.SERVICE_VERSION}`,
'datadog-hostname': `${DefaultServiceCatalogValues.DATADOG_HOSTNAME}`,
'datadog-key': `${DefaultServiceCatalogValues.DATADOG_KEY}`,
'datadog-app-key': `${DefaultServiceCatalogValues.DATADOG_APP_KEY}`,
Expand Down
3 changes: 2 additions & 1 deletion src/semgrep-workflow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ export module semgrepWorkflow {
name: 'Scan',
'runs-on': 'ubuntu-latest',
container: {
image: 'returntocorp/semgrep',
// Reocurring task to check the pinned version SEC-8540
image: 'returntocorp/semgrep@sha256:6c7ab81e4d1fd25a09f89f1bd52c984ce107c6ff33affef6ca3bc626a4cc479b',
},
steps: [
{
Expand Down
8 changes: 4 additions & 4 deletions test/__snapshots__/clickup-cdk.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions test/__snapshots__/datadog-service-catalog.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions test/__snapshots__/semgrep-workflow.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

78 changes: 44 additions & 34 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7ec6793

Please sign in to comment.