Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): bump minNodeVersion to v18 [CLK-321581] #214

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

ahammond
Copy link
Collaborator

No description provided.

@ahammond ahammond requested a review from a team as a code owner September 20, 2023 19:55
@ahammond ahammond self-assigned this Sep 20, 2023
@ahammond ahammond enabled auto-merge (squash) September 20, 2023 19:56
@ahammond ahammond changed the title feat: bump minNodeVersion to v18 [CLK-321581] feat(node): bump minNodeVersion to v18 [CLK-321581] Sep 20, 2023
ahammond and others added 2 commits September 20, 2023 13:04
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #214 (d45cbf9) into main (115f83a) will increase coverage by 0.63%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   98.77%   99.41%   +0.63%     
==========================================
  Files          15       16       +1     
  Lines         327     2038    +1711     
  Branches       78      122      +44     
==========================================
+ Hits          323     2026    +1703     
- Misses          4       12       +8     
Files Changed Coverage Δ
src/utils/parameters.ts 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115f83a...d45cbf9. Read the comment docs.

Copy link

@lbabay-cu lbabay-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahammond ahammond merged commit 15e0405 into main Sep 20, 2023
8 checks passed
@ahammond ahammond deleted the update-min-node-version branch September 20, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants