Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fixing typo in docs [CLK-346284] #216

Merged
merged 1 commit into from
Sep 29, 2023
Merged

chore(docs): fixing typo in docs [CLK-346284] #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/cdk-context-json/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ index aa0d831..d4b75b6 100644
+
+ // cdk.context.json lookup support role
+ const cdkPipelinesVa = core.Environment.usCdkPipelines('us-east-1');
+ const vaStageId = cdkPipeline.getUniqueStageIdentifier(cdkPipelinesVa).addPrefix(['oicd']);
+ const vaStageId = cdkPipeline.getUniqueStageIdentifier(cdkPipelinesVa).addPrefix(['oidc']);
+ oidcPermissions.addStage(
+ GitHubActionsOIDCCdkContextLookupRole.asStage(this, vaStageId.pascal, {...commonProps, namedEnv: cdkPipelinesVa})
+ )
Expand Down
2 changes: 1 addition & 1 deletion docs/cdk-diff/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ This is to make sure you OIDC stages don't conflict with your service.
+ const oidcPermissions = githubPipeline.addWave('OIDC-GitHub-Actions-Permissions');
+ [core.Environment.usQa, core.Environment.globalProd].forEach((factory) => {
+ const namedEnv = factory('us-east-1');
+ const stageId = cdkPipeline.getUniqueStageIdentifier(namedEnv).addPrefix(['oicd']);
+ const stageId = cdkPipeline.getUniqueStageIdentifier(namedEnv).addPrefix(['oidc']);
+ oidcPermissions.addStage(
+ GitHubActionsOIDCPermissions.asStage(this, stageId.pascal, { ...commonProps, namedEnv }),
+ );
Expand Down
Loading