Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(security): Update readme, remove admin rights from the teams[SEC-11179] #238

Merged
merged 3 commits into from
Jan 30, 2024
Merged

chore(security): Update readme, remove admin rights from the teams[SEC-11179] #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94d7b03
chore(security): Update readme, remove admin rights from the teams[SE…
swyrwiak-cu Jan 15, 2024
aea3e90
chore: self mutation
invalid-email-address Jan 15, 2024
2e4a61f
Merge branch 'main' into Szymon-Wyrwiak/SEC-11179/remove-admin-rights…
swyrwiak-cu Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions API.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@ Watch with awe and wonder as projen stamps out a project with
- Collaborators and Teams: https://github.com/time-loop/my-new-repo/settings/access
- You MUST either grant `write` to the `cu-infra-svc-git` machine user (who is a member of the `@time-loop/devops` team) OR you can provide your own `PROJEN_GITHUB_TOKEN` with a GitHub PAT
- Other than the bot user, you should probably avoid granting access directly to users, but instead grant to teams.
- You should probably grant `admin` to your team.
Otherwise, you should almost certainly grant `admin` to your manager.
- You should probably grant `maintain` to your team.
Otherwise, you should almost certainly grant `maintain` to your manager.
- If this is a `-cdk` repo, please grant `admin` to `@time-loop/devops`.
- You should probably grant `write` to the `@time-loop/ft_engineering` team (these are full-time engineers).
- You should probably grant `write` to the `@time-loop/timeloop` team (this is a broader group).
Expand Down
Loading