Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): option to set cdk-diff WF assumed role validity[CLK-462684] #240

Conversation

rudrateja-clickup
Copy link
Contributor

Summary

feat: option to define assumed role validity for cdk-diff workflow OIDC role.

@rudrateja-clickup rudrateja-clickup requested a review from a team as a code owner January 25, 2024 21:00
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (03ffb31) 99.41% compared to head (c6248d0) 99.41%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          16       16           
  Lines        2039     2045    +6     
  Branches      121      122    +1     
=======================================
+ Hits         2027     2033    +6     
  Misses         12       12           
Files Coverage Δ
src/cdk-diff-workflow.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ffb31...c6248d0. Read the comment docs.

@rudrateja-clickup rudrateja-clickup changed the title feat: option to set cdk-diff WF assumed role validity[CLK-462684] feat(cdk): option to set cdk-diff WF assumed role validity[CLK-462684] Jan 25, 2024
src/cdk-diff-workflow.ts Show resolved Hide resolved
@rudrateja-clickup rudrateja-clickup merged commit d1de930 into main Jan 26, 2024
8 checks passed
@rudrateja-clickup rudrateja-clickup deleted the Rudra-Teja/CLK-462684/Update-clickup-projen-library-to-allow-setting-role-duration-seconds branch January 26, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants