Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CdkConstructLibrary): jsii 5.3 [CLK-469895] #246

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

ahammond
Copy link
Collaborator

@ahammond ahammond requested a review from a team as a code owner February 20, 2024 19:15
@ahammond ahammond self-assigned this Feb 20, 2024
@ahammond ahammond enabled auto-merge (squash) February 20, 2024 19:15
Copy link
Contributor

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That warning has been bothering me all of this week, nice to see it resolved!

@ahammond ahammond force-pushed the CLK-469895-jsii-upgrade branch from cca1d9f to f4bf648 Compare February 20, 2024 19:24
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17b0891) 99.35% compared to head (f4bf648) 99.35%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files          17       17           
  Lines        2175     2183    +8     
  Branches      136      136           
=======================================
+ Hits         2161     2169    +8     
  Misses         14       14           
Files Coverage Δ
src/clickup-cdk.ts 97.04% <100.00%> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17b0891...f4bf648. Read the comment docs.

@ahammond ahammond merged commit 04289e9 into main Feb 20, 2024
8 checks passed
@ahammond ahammond deleted the CLK-469895-jsii-upgrade branch February 20, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants