Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "full-timeseries-journey" option to use the full timeseries for the journey #186

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jburnhams
Copy link
Contributor

Used for when you have video clips from a longer gpx track and so want to display the entire journey still

Contributor Checklist

  • Review Contribution Guidelines
  • Agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the GNU Licence
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by maintainers if required.
  • Unit tests created/updated (under tests) to verify logic, and approval tests for UI Widgets
  • Update Examples - Under build-scripts/examples, and regenerate examples docs if required ( make doc-examples )
  • Ensure that tests pass locally - this can be tricky for approval tests with maps or text though.
  • Check that pre-release tests work ( make test-distribution )

@jburnhams
Copy link
Contributor Author

Need to be a bit cleverer with this for the moving journey map so it draws the entire gpx but only downloads that needed for the video. Shouldn't be too hard, will update.

What is hard and I think beyond me is to support the full gpx for the elevation as that's too closely integrated with the video frames

@time4tea
Copy link
Owner

time4tea commented Mar 5, 2024

Thanks for this. I think maybe you have given me an idea...

@jburnhams
Copy link
Contributor Author

Just realised the "odo" metric doesn't use the entire gpx either so perhaps widgets do need to support the fulltimeseries too, plus then can do elevation graph which I'd like. I'll have a look into it at some point unless you think you'd be able to soon?

@time4tea
Copy link
Owner

time4tea commented Mar 7, 2024

Hiya, thanks for this contribution. I will definitely take a look at it, but i don't know if I can merge it as-is. I do think want you to spend time unnecessarily, so please don't go too far in one direction before we can establish that it's the one we want the code to go in.

@jburnhams
Copy link
Contributor Author

Oh don't worry about that, i'm making the changes for myself, just a bonus if you get any use from them too. I'll need odo to use the entire gpx track so was just if you thought you might do that soon then i'd hold off on giving it a go myself

@sashacmc
Copy link

sashacmc commented May 7, 2024

@jburnhams thanks for this feature! I really needed it, I started looking at the code to add it for me, and saw that you had already done it! Super!

@sashacmc
Copy link

sashacmc commented May 7, 2024

I’ll just describe my use case to show why this option is needed, and it’s worth finishing it.
I have quite long routes (several hours), but I don’t need to record a video of the entire route, I’m only interested in certain sections. But in order to get beautiful widgets, I have to record a video of the entire route, then create widgets, and then cut the pieces and join them together.
The solution to write separately GPX (for example, in a phone) and short files looks ideal, but with this option the journey widget (and gradient too) turns out to be not at all interesting.
This option completely solves my problem.

@jeromecornet
Copy link

I've also been experimenting with a similar code change for my videos. My use case is similar where I record the full activity on a cycling head unit, but only take short videos as I'm riding which I then stitch together (see https://www.youtube.com/watch?v=gXQso0IHino for an example).

The only way to display the full map from the gpx/fit file is to do something similar as this PR which makes the full timeseries available to the journey map widget, rather than just the portion of the timeseries that matches the original video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants