Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: authorization todos in rsocket api #173

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix: authorization todos in rsocket api #173

merged 1 commit into from
Dec 13, 2023

Conversation

y9vad9
Copy link
Member

@y9vad9 y9vad9 commented Dec 13, 2023

closes #172

@y9vad9 y9vad9 added the invalid This doesn't seem right label Dec 13, 2023
@y9vad9 y9vad9 requested a review from sliderzxc December 13, 2023 17:04
@y9vad9 y9vad9 self-assigned this Dec 13, 2023
sliderzxc
sliderzxc approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@sliderzxc sliderzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!!

@y9vad9 y9vad9 merged commit 9e73900 into master Dec 13, 2023
1 check passed
@y9vad9 y9vad9 deleted the 172-fix-auth-todos branch December 13, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliderzxc sliderzxc sliderzxc approved these changes

Assignees

@y9vad9 y9vad9

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implemented missing functionality in rsocket-api marked as TODO()
2 participants
@y9vad9 @sliderzxc