Add the ability to play back recently recorded sounds #276
Conversation
This is redundant with the top toolbar but establishes a base for adding more controls.
This is functional but incomplete; the play button starts playback regardless of recording state, there's no way to stop it, etc.
These are enabled/disabled depending on the current state (i.e. can only stop while recording or playing, or can either play or record when stopped), and use the "down" state to indicate when currently playing or recording. The existing stop/start button in the top toolbar will result in playback button state being set correctly, although that button is now redundant and could probably be removed?
When not playing, this allows selection of the position within the buffer to begin playback. When playing, this shows the current playback position. At end of playback, it returns to the previously selected start position.
|
Oh, that one is interesting. As it is, I'm not fully sold, mostly because it takes a significant area of the user interface, for a feature that only some users may need. What do you think of adding a checkbox in the settings dialog to show the playback control ? |
Yes, exactly; playback can be really useful for getting additional feedback on practice. And yes, having the analyzers update to reflect what's playing back was definitely on my mind for future work in this direction. Making this optional sounds pretty reasonable. |
Playback controls are hidden by default. Also, add an option to set the length of the playback buffer.
|
@tlecomte I've added the checkbox to enable the playback controls. It currently defaults to hidden; what do you think about having them shown by default, though? |
|
Thank you very much @celeste-sinead! I feel more comfortable with it hidden by default for now, I'll merge it as is. Thanks again, that's a very nice contribution! |
So, adds a ringbuffer for the last 30s of samples, the ability to play the contents of that buffer, and controls to record/stop/play and select playback position. Useful if you want to hear a recent sound again.
I, um, haven't gotten around to making the buffer length or output device configurable but I'll get to it 🙃