Improve timestamps #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/de/rub/nds/anvilcore/execution/TestRunner.java # src/main/java/de/rub/nds/anvilcore/teststate/AnvilTestRun.java
Conradowatz
requested changes
Jan 16, 2024
pom.xml
Outdated
| @@ -8,7 +8,7 @@ | |||
| </parent> | |||
| <groupId>de.rub.nds</groupId> | |||
| <artifactId>anvil-core</artifactId> | |||
| <version>1.1.4-SNAPSHOT</version> | |||
| <version>1.1.3</version> | |||
There was a problem hiding this comment.
version number should always be left as is at snapshot
| return startInputGenerationTimes; | ||
| } | ||
|
|
||
| public synchronized Date getStartInputGenerationTime(String k) { |
There was a problem hiding this comment.
use descirptive parameter names
| @@ -98,11 +99,16 @@ public void runTests() { | |||
| (MethodBasedTestDescriptor) descriptor; | |||
| Method method = md.getTestMethod(); | |||
| String anvilTestId = null; | |||
| try { | |||
| if (method.getAnnotation(AnvilTest.class) != null) | |||
There was a problem hiding this comment.
alwys use curly braces for if/else statement blocks
| @@ -314,7 +327,7 @@ public void executionFinished( | |||
| public void logTestFinished( | |||
| TestExecutionResult testExecutionResult, TestIdentifier testIdentifier) { | |||
| if (testExecutionResult.getThrowable().isPresent() && testIdentifier.isContainer()) { | |||
| LOGGER.error( | |||
| LOGGER.info( | |||
| @@ -183,8 +195,28 @@ public void finish() { | |||
| scoreContainer.updateForResult(result); | |||
| AnvilContext.getInstance() | |||
| .addTestResult(result, testClass.getName() + "." + testMethod.getName()); | |||
| AnvilContext.getInstance().getMapper().saveTestRunToPath(this); | |||
| // AnvilContext.getInstance().testFinished(uniqueId); | |||
There was a problem hiding this comment.
delete uncommented code
| .getEndInputGenerationTimes() | ||
| .get(this.testMethod.toString()); | ||
| this.setStartInputGenerationTime(startInputGenerationTimes); | ||
| this.setEndInputGenerationTime(endInputGenerationTimes); |
There was a problem hiding this comment.
Could you change it from date to seconds elapsed? Attrbutes could be named like "generationTimeSeconds" and "executionTimeSeconds"
…timestamps # Conflicts: # pom.xml # src/main/java/de/rub/nds/anvilcore/junit/extension/AnvilTestWatcher.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.