Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Swift 5 #51

Open
wants to merge 1 commit into
base: swift
Choose a base branch
from

Conversation

danielrotaermel
Copy link

made it work with Swift 5

Copy link
Owner

@tobihagemann tobihagemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just got a question regarding the Info.plist, which could be reverted in my opinion.

@@ -14,7 +14,6 @@
A59F24061E26994B007FF222 /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = A59F24041E26994B007FF222 /* LaunchScreen.storyboard */; };
A59F24371E26A0B0007FF222 /* Constants.swift in Sources */ = {isa = PBXBuildFile; fileRef = A59F24361E26A0B0007FF222 /* Constants.swift */; };
A59F24391E26A34D007FF222 /* TableViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = A59F24381E26A34D007FF222 /* TableViewController.swift */; };
A59F24471E2785F6007FF222 /* Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = A59F24441E2785F6007FF222 /* Info.plist */; };
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for deleting the Info.plist from the project structure?

@@ -161,7 +161,6 @@
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
A59F24471E2785F6007FF222 /* Info.plist in Resources */,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants