Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asana): Change task title selector #2262

Merged
merged 1 commit into from
Jan 5, 2024
Merged

fix(asana): Change task title selector #2262

merged 1 commit into from
Jan 5, 2024

Conversation

with-shrey
Copy link
Contributor

@with-shrey with-shrey commented Jan 5, 2024

Please remember the Contributing Guidelines ❤️

🌟 What does this PR do?

Fix asana integration for button on the task pane

🐛 Recommendations for testing

image

Go to any project click on a task
The button should be visible on top right for both cases (running TE and no running TE)

📝 Links to relevant issues or information

Closes #2263

Fixes this case from Intercom
https://toggl.slack.com/archives/C069JHPJQU8/p1704441321946629
(not sure if its safe to attach screenshots directly 🤔 )

@with-shrey with-shrey requested a review from Alissonsz January 5, 2024 10:30
@with-shrey with-shrey self-assigned this Jan 5, 2024
@with-shrey with-shrey added the impact: high This is important and we'll work on it as soon as we can. label Jan 5, 2024
Copy link
Contributor

@Alissonsz Alissonsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 🚀

Just don't forget to link the issue in the commit

@with-shrey with-shrey merged commit 96f3c42 into master Jan 5, 2024
1 check passed
@with-shrey with-shrey deleted the fix/asana-task branch January 5, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: high This is important and we'll work on it as soon as we can.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button missing in Asana
2 participants