Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asana): tags and projects spreadsheet selectors #2320

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

askides
Copy link
Contributor

@askides askides commented Aug 12, 2024

Please remember the Contributing Guidelines ❤️

🌟 What does this PR do?

This PR fixes the Asana integrations by changing the selector in the spreadsheet for Projects and Tags.

As an extra, i added the prettier configuration of Toggl, used to keep the files up with code style.

Go commit by commit, the last one is the fix.

🐛 Recommendations for testing

Ensure that starting a TE from the Button will automatically resolve the Project and the Tags (if present) and if the 'Enable Automatic Tagging' is turned on.

closes: #2321
closes: #2317

@askides askides requested review from izontm and with-shrey August 12, 2024 12:11
@askides askides self-assigned this Aug 12, 2024
@with-shrey
Copy link
Contributor

with-shrey commented Aug 12, 2024

Can you also fix #2317

Also please tag the other issue as well in PR boby closes # (there's an integration that triggers intercom chat for support)

@with-shrey
Copy link
Contributor

with-shrey commented Aug 12, 2024

Can confirm it works for my task > list

but doesnt pick up tags on board view (not sure if that'd because of asana ui changes)

@askides
Copy link
Contributor Author

askides commented Aug 13, 2024

Can you also fix #2317

Also please tag the other issue as well in PR boby closes # (there's an integration that triggers intercom chat for support)

Didn't link because i didn't create the issue. Will create it.

@askides
Copy link
Contributor Author

askides commented Aug 13, 2024

@with-shrey done.

@with-shrey with-shrey merged commit 37697b5 into master Aug 13, 2024
1 check passed
@with-shrey with-shrey deleted the fix/asana-selectors branch August 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants