fix(trello): optimize render for slow networks #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be use the mutation observer if its flaky You can pass comma spperated selectors as last argument to render function |
|
I will go deeper into how that function works, as it's kinda confusing, I will try an improvement. |
with-shrey
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remember the Contributing Guidelines ❤️
🌟 What does this PR do?
This PR improves the TogglButton render on Trello even in slow networks.
It does still happen sometimes that the button does not appear but only in very slow networks and with the 'Disable Cache' from the dev tools checked (which is not going to be the case 99% of the time).
Tested with network throttling at 3G speed.
🐛 Recommendations for testing
All changes should be tested across Chrome and Firefox.
Ensure that the button is working.
📝 Links to relevant issues or information
See the slack thread here.