Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): add support for new issues panel #2353

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

askides
Copy link
Contributor

@askides askides commented Nov 22, 2024

Please remember the Contributing Guidelines ❤️

🌟 What does this PR do?

This PR is adding the support for the new Github issue beta page.

image

🐛 Recommendations for testing

All changes should be tested across Chrome and Firefox.

First commit is formatting applied.

  1. Use this branch and link it to the extension.
  2. Go to Github, on the issue page (if you have the beta view enabled) you should now see the button.
  3. Ensure that the title and the issue number are present in the TE description.
  4. Also, it should automatically connect the first project (if exists).

📝 Links to relevant issues or information

closes: #2352

@askides askides requested review from izontm and with-shrey November 22, 2024 10:47
@askides askides self-assigned this Nov 22, 2024
Copy link
Contributor

@izontm izontm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are rendering the button twice, e.g. here.
image

@askides
Copy link
Contributor Author

askides commented Nov 25, 2024

Replicated the issue, it was double rendering as we have the Project Page Side case that was activating with this new one.

Now it should work fine @izontm.

@askides askides requested a review from izontm November 25, 2024 09:48
Copy link
Contributor

@niyiAO niyiAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great! 🚀

@askides askides merged commit cdf3466 into master Nov 26, 2024
1 check passed
@askides askides deleted the fix/github-beta-issues branch November 26, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github new issues panel is not showing the Button
3 participants