Alpha improvement (webmozarts#134)

tomaszhanc · Oct 15, 2019 · a3a574a · a3a574a
1 parent 836e707
commit a3a574a
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/src/Assert.php b/src/Assert.php
@@ -1132,13 +1132,17 @@ public static function unicodeLetters($value, $message = '')
     }
 
     /**
+     * @psalm-assert string $value
+     *
      * @param mixed  $value
      * @param string $message
      *
      * @throws InvalidArgumentException
      */
     public static function alpha($value, $message = '')
     {
+        static::string($value);
+
         $locale = \setlocale(LC_CTYPE, 0);
         \setlocale(LC_CTYPE, 'C');
         $valid = !\ctype_alpha($value);

diff --git a/tests/AssertTest.php b/tests/AssertTest.php
@@ -297,6 +297,8 @@ public function getTests()
             array('alpha', array('abcd'), true),
             array('alpha', array('ab1cd'), false),
             array('alpha', array(''), false),
+            array('alpha', array(66), false),
+            array('alpha', array(array()), false),
             array('digits', array('1234'), true),
             array('digits', array('12a34'), false),
             array('digits', array(''), false),

diff --git a/tests/static-analysis/assert-alpha.php b/tests/static-analysis/assert-alpha.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace Webmozart\Assert\Tests\StaticAnalysis;
+
+use Webmozart\Assert\Assert;
+
+/**
+ * @param mixed $value
+ */
+function consume($value) : string
+{
+    Assert::alpha($value);
+    return $value;
+}