Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit hooks with mypy fix #3454

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Update pre-commit hooks with mypy fix #3454

merged 2 commits into from
Dec 3, 2024

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Dec 3, 2024 •
edited
Loading

Update pre-commit.com hooks as they required one manual change for mypy.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Closes: #3453

@ssbarnea ssbarnea changed the title chore/pre commit hooks Address mypy failure Dec 3, 2024
@ssbarnea ssbarnea marked this pull request as ready for review December 3, 2024 11:47
@ssbarnea ssbarnea requested a review from gaborbernat as a code owner December 3, 2024 11:47
@ssbarnea ssbarnea changed the title Address mypy failure Update pre-commit hooks with mypy fix Dec 3, 2024
@ssbarnea ssbarnea enabled auto-merge (squash) December 3, 2024 11:49
@gaborbernat gaborbernat disabled auto-merge December 3, 2024 13:53
@gaborbernat gaborbernat enabled auto-merge (squash) December 3, 2024 13:53
@gaborbernat gaborbernat merged commit 0e33d24 into main Dec 3, 2024
28 checks passed
@gaborbernat gaborbernat deleted the chore/pre-commit-hooks branch December 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat Awaiting requested review from gaborbernat gaborbernat is a code owner

Assignees
No one assigned
Labels
bot:chronographer:skip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssbarnea @gaborbernat