transloadit: Emit assembly progress events #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature is now available in production and can be enabled by adding |
Murderlon
approved these changes
Sep 5, 2023
|
Looks good and sorry for letting it hang for so long. |
|
Thank you, no worries. Just two brief questions:
|
|
I assumed this is still experimental indeed, so we shouldn't type it because then we have to do a major to change the type. Same for docs I think. We just shouldn't forget that we still need to add the types and docs. |
|
That makes sense. Then this should be good to go now. |
This was referenced Sep 5, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 5, 2023
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/angular | 0.6.0 | @uppy/dashboard | 3.5.2 | | @uppy/aws-s3 | 3.3.0 | @uppy/transloadit | 3.3.0 | | @uppy/aws-s3-multipart | 3.6.0 | @uppy/tus | 3.2.0 | | @uppy/companion | 4.8.2 | @uppy/utils | 5.5.0 | | @uppy/companion-client | 3.4.0 | @uppy/xhr-upload | 3.4.0 | | @uppy/core | 3.5.0 | uppy | 3.15.0 | - @uppy/transloadit: Emit assembly progress events (Marius / #4603) - @uppy/transloadit: remove Socket.io (Antoine du Hamel / #4281) - meta: example: update Angular example to 16.x (Antoine du Hamel / #4642) - @uppy/angular: upgrade to Angular 16.x (Antoine du Hamel / #4642) - @uppy/companion: refactor `getProtectedHttpAgent` to make TS happy (Antoine du Hamel / #4654) - @uppy/companion: Alias "removeListener" as "off" in Redis emitter (Elliot Dickison / #4647) - @uppy/aws-s3-multipart,@uppy/aws-s3,@uppy/companion-client,@uppy/core,@uppy/tus,@uppy/utils,@uppy/xhr-upload: Move remote file upload logic into companion-client (Merlijn Vos / #4573) - @uppy/dashboard: when showAddFilesPanel is true, aria-hidden should be the opposite (Artur Paikin / #4643)
Thompson1985
approved these changes
Nov 20, 2024
Thompson1985
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just a small PR which forwards the Assembly progress events from the WebSocket/SEE stream to the end user and also integrates the progress information into the status bar/dashboard. This feature is not yet available in production, but can already be tested out in staging.
Besides emitting the events, we could also consider additional integrations into Uppy, such as: