Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide upload button when state is recovered if hideUploadButton is true #4657

Closed

Conversation

maddy-jo
Copy link
Contributor

@maddy-jo maddy-jo commented Sep 1, 2023

This is a draft of a change for the behavior documented in this community forum post. When Golden Retriever is used, recovered state overrides the user-supplied option for hideUploadButton; this change makes the status bar not render the button if state has been recovered.

There may be a bit of styling changes required if the direction of this PR is acceptable. If the button is not rendered and the progress bar has display: none, the container is still not hidden and has the same height as if it had contents.

Alternatively, I understand if the current behavior is intended and developers are responsible for hiding the button and container via our own CSS. That seems perfectly reasonable.

I will be unavailable for the next week but appreciate any feedback on this PR. Thank you!

@Murderlon Murderlon self-assigned this Jun 3, 2024
@lakesare
Copy link
Contributor

Oh just stumbled upon this PR - I'm fixing exactly this issue in the following PR: #5350 (not yet merged).
Our changes are quite similar, except I'm also addressing the container height issue you're describing.


@maddy-jo, thanks for the PR, closing in favour of #5350.

@lakesare lakesare closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants