add test endpoint for dynamic oauth creds #4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows us to test it on uppy.io (we can enable it for one provider like google drive for example)
3 tasks
Murderlon
reviewed
Sep 18, 2023
| @@ -80,7 +100,7 @@ export default () => { | |||
| proudlyDisplayPoweredByUppy: true, | |||
| note: `${JSON.stringify(restrictions)}`, | |||
| }) | |||
| // .use(GoogleDrive, { target: Dashboard, companionUrl: COMPANION_URL, companionAllowedHosts }) | |||
| .use(GoogleDrive, { target: Dashboard, companionUrl: COMPANION_URL, companionAllowedHosts, ...getCompanionKeysParams('GOOGLE_DRIVE') }) | |||
There was a problem hiding this comment.
@arturi should RemoteSources support this too? Otherwise you need both the regular plugin and remote sources.
There was a problem hiding this comment.
maybe we should do that in a different PR anyways?
There was a problem hiding this comment.
For sure, just wanted to make Artur aware.
# Conflicts: # packages/@uppy/companion/src/companion.js
Murderlon
approved these changes
Sep 20, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 29, 2023
| Package | Version | Package | Version | | ------------------------- | ------- | ------------------------- | ------- | | @uppy/audio | 1.1.3 | @uppy/store-default | 3.0.4 | | @uppy/aws-s3 | 3.3.1 | @uppy/store-redux | 3.0.4 | | @uppy/aws-s3-multipart | 3.7.0 | @uppy/svelte | 3.1.0 | | @uppy/companion | 4.9.1 | @uppy/thumbnail-generator | 3.0.5 | | @uppy/companion-client | 3.4.1 | @uppy/transloadit | 3.3.1 | | @uppy/compressor | 1.0.4 | @uppy/tus | 3.3.1 | | @uppy/core | 3.5.1 | @uppy/utils | 5.5.1 | | @uppy/dashboard | 3.5.4 | @uppy/webcam | 3.3.3 | | @uppy/image-editor | 2.2.1 | @uppy/xhr-upload | 3.4.1 | | @uppy/remote-sources | 1.0.4 | uppy | 3.17.0 | - meta: add Prettier (Antoine du Hamel / #4707) - @uppy/aws-s3-multipart: retry signature request (Merlijn Vos / #4691) - meta: update linter config to cover more files (Mikael Finstad / #4706) - @uppy/image-editor: ImageEditor.jsx - remove 1px black lines (Evgenia Karunus / #4678) - meta: delete `.yarn/releases/yarn-3.4.1.cjs` (Antoine du Hamel) - meta: fix linter errors (Antoine du Hamel / #4704) - @uppy/utils: test: migrate to Vitest for Uppy core and Uppy plugins (Antoine du Hamel / #4700) - meta: run corepack yarn (Mikael Finstad) - @uppy/companion: upgrade TS target (Mikael Finstad / #4670) - @uppy/companion: use deferred length for tus streams (Mikael Finstad / #4697) - @uppy/companion-client: fix a refresh token race condition (Mikael Finstad / #4695) - meta: add companion hotfix doc (Mikael Finstad / #4683) - meta: run type checks also for companion and add files to docker (Mikael Finstad / #4688) - @uppy/svelte: revert breaking change (Antoine du Hamel / #4694) - meta: Update yarn.lock (Artur Paikin) - @uppy/companion: fix instagram/facebook auth error regression (Mikael Finstad / #4692) - @uppy/aws-s3-multipart: aws-s3-multipart - call `#setCompanionHeaders` in `setOptions` (jur-ng / #4687) - @uppy/svelte: Upgrade Svelte to 4 (frederikhors / #4652) - @uppy/companion: add test endpoint for dynamic oauth creds (Mikael Finstad / #4667) - meta: fix VITE_COMPANION_ALLOWED_HOSTS (Mikael Finstad / #4690) - @uppy/companion: fix edge case for pagination on root (Mikael Finstad / #4689) - @uppy/companion: fix onedrive pagination (Mikael Finstad / #4686)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows us to test it on uppy.io (we can enable it for one provider like google drive for example)