remove s3 endpoints if s3 disabled #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will give a 404 instead of throwing an error also allow disabling URL endpoint too
aduh95
approved these changes
Sep 13, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 18, 2023
| Package | Version | Package | Version | | ------------------ | ------- | ------------------ | ------- | | @uppy/companion | 4.9.0 | @uppy/locales | 3.3.1 | | @uppy/compressor | 1.0.3 | @uppy/tus | 3.3.0 | | @uppy/dashboard | 3.5.3 | uppy | 3.16.0 | | @uppy/image-editor | 2.2.0 | | | - @uppy/tus: Fix: Utilize user-defined onSuccess, onError, and onProgress callbacks in @uppy/tus (choi sung keun / #4674) - @uppy/dashboard: Make file-editor:cancel event fire when the Image Editor “cancel” button is pressed (Artur Paikin / #4684) - @uppy/companion: add missing credentialsURL for box (Mikael Finstad / #4681) - @uppy/companion: remove s3 endpoints if s3 disabled (Mikael Finstad / #4675) - meta: use latest Node.js version for tests (Antoine du Hamel / #4662) - meta: Improve Contributing.md (Evgenia Karunus / #4633) - @uppy/compressor: update file.meta.name after compression, becase format/extension might have changed (Artur Paikin / #4645) - @uppy/companion: Onedrive refresh tokens (Mikael Finstad / #4655) - @uppy/companion: catch "invalid initialization vector" instead of crashing (Mikael Finstad / #4661) - @uppy/image-editor: Improve image rotation (Evgenia Karunus / #4639) - @uppy/locales: Feature/updating i18n farsi (Parsa Arvaneh / #4638)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will give a 404 instead of throwing an error
also allow disabling URL endpoint too