Migrate to sdkmanager and support latest SDK
#992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate to `sdkmanager` command to install/update components - Updated initial Android SDK download to version 26.1.1 - Support for Android SDK 28 - Use new emulator (added to $PATH)
|
The continuous-integration/travis-ci/pr is failing due to issues unrelated to this pull request. Issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdkmanagercommand to install/update componentsWhat is the problem that this PR is trying to fix?
The current version uses the deprecated android binary instead of sdkmanager and uses the old emulator. The highest supported SDK version is Android SDK 25.
What approach did you choose and why?
I updated the recipe to support the latest versions.
How can you make sure the change works as expected?
I tested it but please test it again. ;)
Would you like any additional feedback?
Is this change ok and if not what can be improved? Feedback is very welcome!
Fixes #965