Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The semicolon should be interted before comment #279

Closed
wants to merge 1 commit into from

Conversation

cuyl
Copy link

@cuyl cuyl commented Dec 15, 2023

  • semicolon should be inserted before comment

Checklist:

  • All tests pass in CI.
  • The script/parse-examples passes without issues.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

 - semicolon should be inserted before comment
@cuyl cuyl force-pushed the fix-automatic-semicolon branch from 8310a4d to c9af3d1 Compare December 15, 2023 14:43
@amaanq
Copy link
Member

amaanq commented Jan 31, 2024

I think I've managed this in my recent fixes, let me know if it's not okay or has any issues.

@amaanq amaanq closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants