Remove iceberg.rest-catalog.parent-namespace config property
#24269
+7
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/iceberg-rest-parent-workspace
branch
from
03ee58c
to
7ea6639
Compare
The property was added for supporting Unity catalog. They changed the behavior to respect warehouse property in unitycatalog/unitycatalog#324.
ebyhr
force-pushed
the
ebi/iceberg-rest-parent-workspace
branch
from
7ea6639
to
6ebba64
Compare
mayankvadariya
approved these changes
Nov 27, 2024
| throw new TrinoException(NOT_SUPPORTED, "Nested namespace is not enabled for this catalog"); | ||
| } | ||
| return Arrays.stream(namespace.levels(), this.parentNamespace.length(), namespace.length()) | ||
| .collect(joining(NAMESPACE_SEPARATOR)); | ||
| return namespace.toString(); |
There was a problem hiding this comment.
we can use NAMESPACE_SEPARATOR instead.
Suggested change
| return namespace.toString(); | |
| return String.join(NAMESPACE_SEPARATOR, namespace.levels()); |
| @@ -259,7 +259,7 @@ public static void main(String[] args) | |||
| .addIcebergProperty("iceberg.security", "read_only") | |||
| .addIcebergProperty("iceberg.catalog.type", "rest") | |||
| .addIcebergProperty("iceberg.rest-catalog.uri", unityCatalog.uri() + "/iceberg") | |||
| .addIcebergProperty("iceberg.rest-catalog.parent-namespace", "unity") | |||
| .addIcebergProperty("iceberg.rest-catalog.warehouse", "unity") | |||
There was a problem hiding this comment.
Please update this prop in TestIcebergUnityRestCatalogConnectorSmokeTest as well.
Do we need to update unity image with the changes from the unity PR you linked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The property was added for supporting Unity catalog.
They changed the behavior to respect
warehouseproperty in unitycatalog/unitycatalog#324.Release notes