NAS-128779 / 24.10 / Simplify File artifact implementation

[themylogin]

In the previous implementation, all files in the directory were opened at once, which resulted in being out of fds if a directory had many files (e.g. job logs directory)

[themylogin]

time 3:00

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-128779

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 93.02%. Comparing base (d4e5d65) to head (0fae0d4).

Files	Patch %	Lines
ixdiagnose/artifacts/items/file.py	40.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #192      +/-   ##
==========================================
- Coverage   93.26%   93.02%   -0.25%     
==========================================
  Files         101      101              
  Lines        2228     2221       -7     
==========================================
- Hits         2078     2066      -12     
- Misses        150      155       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.