Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130454 / 24.10 / Add audit details to debug #206

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

anodos325
Copy link
Contributor

This commit adds the following information to the debugs we collect

  1. Basic audit configuration (retention period, quota, space used, etc)

  2. Audit query of recent middleware method calls. List of 100 most recent audited configuration changes on the NAS. This should help support triage changes users made that may be to blame for an issue encountered.

This commit adds the following information to the debugs we collect

1. Basic audit configuration (retention period, quota, space used, etc)

2. Audit query of recent middleware method calls. List of 100 most
   recent audited configuration changes on the NAS. This should help
   support triage changes users made that may be to blame for an issue
   encountered.
@anodos325 anodos325 added the jira label Aug 6, 2024
@bugclerk
Copy link

bugclerk commented Aug 6, 2024

@bugclerk bugclerk changed the title Add audit details to debug NAS-130454 / 24.10 / Add audit details to debug Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (bf6d6c6) to head (6490f62).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   92.30%   92.33%   +0.02%     
==========================================
  Files         100      101       +1     
  Lines        2223     2230       +7     
==========================================
+ Hits         2052     2059       +7     
  Misses        171      171              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anodos325 anodos325 merged commit f2fd343 into master Aug 6, 2024
6 checks passed
@anodos325 anodos325 deleted the add-audit-debug branch August 6, 2024 13:13
@bugclerk
Copy link

bugclerk commented Aug 6, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants