Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132534 / 24.10.1 / Add jbof and rdma (by bmeagherix) #243

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

bugclerk
Copy link

@bugclerk bugclerk commented Nov 15, 2024

Noticed these were missing.

Original PR: #242
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132534

(cherry picked from commit ff18617)
(cherry picked from commit 47ca65e)
(cherry picked from commit b4aa9a5)
(cherry picked from commit 8f15650)
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@b694126). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ixdiagnose/plugins/network.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel     #243   +/-   ##
=====================================================
  Coverage                      ?   91.09%           
=====================================================
  Files                         ?      103           
  Lines                         ?     2348           
  Branches                      ?        0           
=====================================================
  Hits                          ?     2139           
  Misses                        ?      209           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yocalebo yocalebo merged commit deb1e1f into stable/electriceel Nov 15, 2024
6 checks passed
@yocalebo yocalebo deleted the NAS-132534-24.10.1 branch November 15, 2024 16:37
@bugclerk
Copy link
Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants