Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132555 / 24.10.1 / Include snmp in plugins diagnostic. (by mgrimesix) #247

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

bugclerk
Copy link

SNMP is missing from the diagnostic.
This PR adds SNMP configuration and associated files to a diagnostic.

Original PR: #244
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132555

(cherry picked from commit aa6d7b6)
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/electriceel@5a694be). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel     #247   +/-   ##
=====================================================
  Coverage                      ?   91.12%           
=====================================================
  Files                         ?      104           
  Lines                         ?     2356           
  Branches                      ?        0           
=====================================================
  Hits                          ?     2147           
  Misses                        ?      209           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mgrimesix mgrimesix requested a review from anodos325 November 19, 2024 18:47
@anodos325 anodos325 merged commit 3d48030 into stable/electriceel Nov 19, 2024
6 checks passed
@anodos325 anodos325 deleted the NAS-132555-24.10.1 branch November 19, 2024 18:49
@bugclerk
Copy link
Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants