Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-127428 / 24.10 / Installer HTTP API #77

Merged
merged 2 commits into from
Apr 30, 2024
Merged

NAS-127428 / 24.10 / Installer HTTP API #77

merged 2 commits into from
Apr 30, 2024

Conversation

themylogin
Copy link
Contributor

No description provided.

@themylogin themylogin added the WIP Work In Progress label Apr 16, 2024
@bugclerk
Copy link

Jira URL: https://ixsystems.atlassian.net/browse/NAS-127428

@bugclerk bugclerk changed the title Installer HTTP API NAS-127428 / 24.10 / Installer HTTP API Apr 16, 2024
@themylogin themylogin removed the WIP Work In Progress label Apr 17, 2024
@themylogin themylogin requested a review from yocalebo April 17, 2024 08:55
@themylogin
Copy link
Contributor Author

time 30:00

@yocalebo yocalebo requested review from a team and removed request for yocalebo April 17, 2024 10:23
sonicaj
sonicaj approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@sonicaj sonicaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a github action perhaps which can generate the documentation on merges to master ?

@themylogin
Copy link
Contributor Author

@sonicaj can github actions commit?

@sonicaj
Copy link
Member

sonicaj commented Apr 30, 2024

@themylogin yes, please see https://github.com/truenas/charts/blob/master/.github/workflows/update_catalog.yaml

@themylogin themylogin merged commit 709539c into master Apr 30, 2024
2 checks passed
@themylogin themylogin deleted the NAS-127428 branch April 30, 2024 11:32
@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonicaj sonicaj sonicaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themylogin @bugclerk @sonicaj