Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132372 / 25.04 / Add /dev/zvol root for explorer #11106

Merged
merged 8 commits into from
Dec 4, 2024
Merged

Conversation

RehanY147
Copy link
Contributor

Changes:

Adds option to load zvols alongside datasets by providing two root paths. /dev/zvol alongside /mnt when calling filesystem.listdir endpoint. ix-explorer root property should be set to / for this. Default root for ix-explorer is /mnt

Testing:

Test on the TrueCloud Task Form. The path explorer should show '/' as it's root. When expanded, it should show two children paths. '/mnt' and '/dev/zvol'. When expanded, '/mnt' should show the normal datasets and '/dev/zvol' should show the zvols.

@RehanY147 RehanY147 requested a review from a team as a code owner November 28, 2024 00:33
@RehanY147 RehanY147 requested review from bvasilenko and removed request for a team November 28, 2024 00:33
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-132372: Add /dev/zvol root for explorer NAS-132372 / 25.04 / Add /dev/zvol root for explorer Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (1e0dd8e) to head (e9613d4).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/app/services/filesystem.service.ts 76.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11106      +/-   ##
==========================================
- Coverage   82.39%   82.39%   -0.01%     
==========================================
  Files        1648     1647       -1     
  Lines       57926    57917       -9     
  Branches     5947     5950       +3     
==========================================
- Hits        47729    47719      -10     
- Misses      10197    10198       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to address the [ENOENT] Directory /dev/zvol does not exist error that may happen if user does not have any zvols.

directoriesOnly?: boolean;
showHiddenFiles?: boolean;
includeSnapshots?: boolean;
dsAndZvols?: boolean;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not abbreviate

@RehanY147 RehanY147 requested a review from undsoft November 29, 2024 23:35
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit hacky, but it works.
Can we change it so that the icon used for zvols is not a generic file icon?

@RehanY147 RehanY147 requested a review from undsoft December 4, 2024 01:06
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While symlink icon is good, I meant inferring that something is a zvol and using a zvol icon we use on Datasets page.
Снимок экрана 2024-12-04 в 09 34 39

@RehanY147 RehanY147 requested review from undsoft and removed request for bvasilenko December 4, 2024 22:18
@RehanY147 RehanY147 enabled auto-merge (squash) December 4, 2024 22:18
@RehanY147 RehanY147 merged commit b4c2eb0 into master Dec 4, 2024
9 checks passed
@RehanY147 RehanY147 deleted the NAS-132372 branch December 4, 2024 22:52
@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

JIRA ticket https://ixsystems.atlassian.net/browse/NAS-132372 is targeted to the following versions which have not received their corresponding PRs: 24.10.2

@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants