NAS-132759 / 25.04 / Rework Installed Apps

[bvasilenko]

Changes:

Used new master-detail view component on installed apps page

Testing:

Double check that all features of the installed Apps page work

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132759

[codecov]

Codecov Report

Attention: Patch coverage is 79.55272% with 64 lines in your changes missing coverage. Please review.

Project coverage is 82.56%. Comparing base (28145e9) to head (fc0c751).
Report is 28 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...stalled-apps-list/installed-apps-list.component.ts	77.45%	62 Missing ⚠️
...ponents/installed-apps/installed-apps.component.ts	85.71%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11120      +/-   ##
==========================================
+ Coverage   82.38%   82.56%   +0.18%     
==========================================
  Files        1648     1650       +2     
  Lines       57694    58008     +314     
  Branches     5944     5954      +10     
==========================================
+ Hits        47532    47896     +364     
+ Misses      10162    10112      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AlexKarpov98]

Looks good overall but can be improved.

[AlexKarpov98]

Would be good to rework that to have a separate component for installed-apps-list, so the installed-apps component html may become smaller.

As example:

<ix-page-header>
  <ix-all-instances-header></ix-all-instances-header>
</ix-page-header>

<ix-master-detail-view
  #masterDetailView="masterDetailViewContext"
  [selectedItem]="selectedInstance()"
>
  <ix-instance-list
    master
    [isMobileView]="masterDetailView.isMobileView()"
    [showMobileDetails]="masterDetailView.showMobileDetails()"
    (toggleShowMobileDetails)="masterDetailView.toggleShowMobileDetails($event)"
  ></ix-instance-list>

  <ng-container detail-name>
    {{ selectedInstance()?.name }}
  </ng-container>

  <ng-container detail>
    @if (selectedInstance()) {
      <ix-instance-details
        [instance]="selectedInstance()"
      ></ix-instance-details>
    }
  </ng-container>
</ix-master-detail-view>

[AlexKarpov98]

As well would be good to extract bulk actions to the separate component
Example:

@if (checkedInstances?.length > 0) {
    <ix-instance-list-bulk-actions
      [checkedInstances]="checkedInstances"
      (resetBulkSelection)="resetSelection()"
    ></ix-instance-list-bulk-actions>
  }

[RehanY147]

Seems to be working the same as before

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.