Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132725 / 25.04 / UI - Do not allow user to delete themselves #11121

Merged
merged 2 commits into from
Dec 4, 2024
Merged

NAS-132725 / 25.04 / UI - Do not allow user to delete themselves #11121

merged 2 commits into from
Dec 4, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

  • Create another admin user.
  • Login as another admin user and try delete that new user. (it's impossible now)

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 2, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 2, 2024 08:57
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team December 2, 2024 08:57
@bugclerk
Copy link
Contributor

bugclerk commented Dec 2, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132725

@bugclerk bugclerk changed the title NAS-132725: UI - Do not allow user to delete themselves NAS-132725 / 25.04 / UI - Do not allow user to delete themselves Dec 2, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (8f8ac70) to head (948dfef).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #11121   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files        1648     1648           
  Lines       57884    57889    +5     
  Branches     5955     5955           
=======================================
+ Hits        47691    47696    +5     
  Misses      10193    10193

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bvasilenko
bvasilenko approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@AlexKarpov98 AlexKarpov98 merged commit 05a0c9d into master Dec 4, 2024
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132725 branch December 4, 2024 14:20
@bugclerk bugclerk mentioned this pull request Dec 4, 2024
Merged
@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bvasilenko bvasilenko bvasilenko approved these changes

Assignees

@AlexKarpov98 AlexKarpov98

Labels
backport-24.10.2 backported no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKarpov98 @bugclerk @bvasilenko