Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132751 / 25.04 / Cloud Credentials: It is not possible to delete cloud credentials #11122

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing:

See custom error as an example:

Screen.Recording.2024-12-02.at.11.38.42.mov

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 2, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 2, 2024 09:39
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team December 2, 2024 09:39
@bugclerk bugclerk changed the title NAS-132751: Cloud Credentials: It is not possible to delete cloud credentials NAS-132751 / 25.04 / Cloud Credentials: It is not possible to delete cloud credentials Dec 2, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 2, 2024

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.39%. Comparing base (036fc6c) to head (d1ba4d0).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11122   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files        1649     1649           
  Lines       57889    57891    +2     
  Branches     5956     5956           
=======================================
+ Hits        47696    47698    +2     
  Misses      10193    10193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error is shown now.

@bugclerk
Copy link
Contributor

bugclerk commented Dec 2, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants