Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132776 / 25.04 / Implement Associated Extents card in iSCSI #11130

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Result:

NAS-132776.mov

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 3, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 3, 2024 09:32
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team December 3, 2024 09:32
@bugclerk bugclerk changed the title NAS-132776: Implement Associated Extents card in iSCSI NAS-132776 / 25.04 / Implement Associated Extents card in iSCSI Dec 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 3, 2024

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 94.52055% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (5e28742) to head (3350b73).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/services/iscsi.service.ts 0.00% 2 Missing ⚠️
...ed-target-form/associated-target-form.component.ts 94.44% 1 Missing ⚠️
...targets/target-details/target-details.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11130      +/-   ##
==========================================
- Coverage   82.42%   82.39%   -0.03%     
==========================================
  Files        1649     1649              
  Lines       58011    57941      -70     
  Branches     5957     5947      -10     
==========================================
- Hits        47814    47741      -73     
- Misses      10197    10200       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Safari Version 18.1.1 (20619.2.8.11.12)

Other than that looks good

@AlexKarpov98
Copy link
Contributor Author

@denysbutenko - good catch, please create a separate ticket for that one ☝️

@AlexKarpov98 AlexKarpov98 merged commit 6bd5eda into master Dec 3, 2024
11 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132776 branch December 3, 2024 22:50
@bugclerk
Copy link
Contributor

bugclerk commented Dec 3, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants