Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132767 / 25.04 / Fix payload for cloud sync task #11133

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

denysbutenko
Copy link
Member

Changes:

Fix payload for cloud sync task

Testing:

Check details in ticket.

@bugclerk bugclerk changed the title NAS-132767: Fix payload for cloud sync task NAS-132767 / 25.04 / Fix payload for cloud sync task Dec 3, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 3, 2024

@denysbutenko denysbutenko marked this pull request as ready for review December 3, 2024 18:27
@denysbutenko denysbutenko requested a review from a team as a code owner December 3, 2024 18:27
@denysbutenko denysbutenko requested review from bvasilenko and removed request for a team December 3, 2024 18:27
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.40%. Comparing base (a17536c) to head (c8972fa).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...what-and-when/cloudsync-what-and-when.component.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11133   +/-   ##
=======================================
  Coverage   82.39%   82.40%           
=======================================
  Files        1647     1647           
  Lines       57915    57923    +8     
  Branches     5950     5953    +3     
=======================================
+ Hits        47718    47729   +11     
+ Misses      10197    10194    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works as expected

@bugclerk
Copy link
Contributor

bugclerk commented Dec 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants