-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS-132607 / 25.04 / Adapting to new API #11143
Conversation
# Conflicts: # src/app/interfaces/api/api-event-directory.interface.ts # src/assets/i18n/zh-hans.json
# Conflicts: # src/assets/i18n/pl.json
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #11143 +/- ##
==========================================
+ Coverage 82.39% 82.42% +0.03%
==========================================
Files 1647 1648 +1
Lines 57900 58006 +106
Branches 5945 5970 +25
==========================================
+ Hits 47708 47814 +106
Misses 10192 10192 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ErrorHandlerService seems to have some issue that's not present in master.
Screen.Recording.2024-12-05.at.5.12.36.AM.mov
@RehanY147 Shape of middleware endpoint has been changed. I will create a separate ticket for it after this PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scope of the ticket is large. But after testing for a while, things seem to be working Ok.
This PR has been merged and conversations have been locked. |
Changes:
Adapts to new API. Major changes in error handling, subscriptions and events.
Testing
Regression testing of everything websocket related.