Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132607 / 25.04 / Adapting to new API #11143

Merged
merged 13 commits into from
Dec 6, 2024
Merged

NAS-132607 / 25.04 / Adapting to new API #11143

merged 13 commits into from
Dec 6, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 4, 2024

Changes:

Adapts to new API. Major changes in error handling, subscriptions and events.

Testing
Regression testing of everything websocket related.

@undsoft undsoft requested a review from a team as a code owner December 4, 2024 15:50
@undsoft undsoft requested review from RehanY147 and removed request for a team December 4, 2024 15:50
@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

@bugclerk bugclerk changed the title NAS-132607: Adapting to new API NAS-132607 / 25.04 / Adapting to new API Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 63 lines in your changes missing coverage. Please review.

Project coverage is 82.42%. Comparing base (05a0c9d) to head (49a1b4f).
Report is 6 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/services/error-handler.service.ts 64.28% 10 Missing ⚠️
src/app/services/shell.service.ts 11.11% 8 Missing ⚠️
...tasets/modules/snapshots/store/snapshot.effects.ts 0.00% 5 Missing ⚠️
src/app/modules/jobs/store/job.effects.ts 20.00% 4 Missing ⚠️
...p/pages/apps/store/installed-apps-store.service.ts 20.00% 4 Missing ⚠️
src/app/services/websocket/api.service.ts 83.33% 4 Missing ⚠️
src/app/app.component.ts 0.00% 3 Missing ⚠️
...h-connection-form/ssh-connection-form.component.ts 25.00% 3 Missing ⚠️
...alization/stores/virtualization-instances.store.ts 25.00% 3 Missing ⚠️
src/app/pages/vm/vm-wizard/vm-wizard.component.ts 0.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11143      +/-   ##
==========================================
+ Coverage   82.39%   82.42%   +0.03%     
==========================================
  Files        1647     1648       +1     
  Lines       57900    58006     +106     
  Branches     5945     5970      +25     
==========================================
+ Hits        47708    47814     +106     
  Misses      10192    10192              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrorHandlerService seems to have some issue that's not present in master.

Screen.Recording.2024-12-05.at.5.12.36.AM.mov

@undsoft
Copy link
Collaborator Author

undsoft commented Dec 5, 2024

@RehanY147 Shape of middleware endpoint has been changed. I will create a separate ticket for it after this PR is merged.
But I have fixed the error reporting.

@undsoft undsoft requested a review from RehanY147 December 5, 2024 12:57
Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of the ticket is large. But after testing for a while, things seem to be working Ok.

@undsoft undsoft merged commit 3408719 into master Dec 6, 2024
11 checks passed
@undsoft undsoft deleted the NAS-132607 branch December 6, 2024 11:18
@bugclerk
Copy link
Contributor

bugclerk commented Dec 6, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants