Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132887 / 25.04 / Migrate more inputs to signals #11144

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 4, 2024

Testing:

Test for regressions.

@undsoft undsoft requested a review from a team as a code owner December 4, 2024 18:03
@undsoft undsoft requested review from denysbutenko and removed request for a team December 4, 2024 18:03
@bugclerk bugclerk changed the title NAS-132887: Migrate more inputs to signals NAS-132887 / 25.04 / Migrate more inputs to signals Dec 4, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 4, 2024

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 80.80000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 82.39%. Comparing base (05a0c9d) to head (2572539).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tives/tree-virtual-scroll-node-outlet.directive.ts 0.00% 7 Missing ⚠️
...ader/components/app-loader/app-loader.component.ts 0.00% 3 Missing ⚠️
...-selection-vdev/manual-selection-vdev.component.ts 0.00% 3 Missing ⚠️
...ponents/general-dialog/general-dialog.component.ts 33.33% 2 Missing ⚠️
src/app/modules/dialog/dialog.service.ts 33.33% 2 Missing ⚠️
src/app/modules/loader/app-loader.service.ts 0.00% 2 Missing ⚠️
...tials-select/cloud-credentials-select.component.ts 85.71% 1 Missing ⚠️
...ynamic-form-item/ix-dynamic-form-item.component.ts 85.71% 1 Missing ⚠️
...ms/components/ix-combobox/ix-combobox.component.ts 92.30% 1 Missing ⚠️
...ules/ix-table/directives/ix-body-cell.directive.ts 85.71% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11144   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files        1647     1647           
  Lines       57900    57960   +60     
  Branches     5945     5950    +5     
=======================================
+ Hits        47708    47759   +51     
- Misses      10192    10201    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@undsoft undsoft enabled auto-merge (squash) December 5, 2024 12:33
@undsoft undsoft merged commit 8d8fa56 into master Dec 5, 2024
9 checks passed
@undsoft undsoft deleted the NAS-132887 branch December 5, 2024 13:00
@bugclerk
Copy link
Contributor

bugclerk commented Dec 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants