Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132909 / 25.04 / Fix audit page for LOGIN_TWOFACTOR #11153

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 6, 2024

Testing:

Original issue is reproducible by changing:

const credentialType = log.event_data?.credentials?.credentials;

in getMiddlewareLogImportantData
to

const credentialType = 'LOGIN_TWOFACTOR' as any;

@undsoft undsoft requested a review from a team as a code owner December 6, 2024 14:37
@undsoft undsoft requested review from denysbutenko and removed request for a team December 6, 2024 14:37
@bugclerk bugclerk changed the title NAS-132909: Fix audit page for LOGIN_TWOFACTOR NAS-132909 / 25.04 / Fix audit page for LOGIN_TWOFACTOR Dec 6, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 6, 2024

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (3408719) to head (5970c50).
Report is 5 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../pages/audit/utils/get-log-important-data.utils.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11153   +/-   ##
=======================================
  Coverage   82.62%   82.62%           
=======================================
  Files        1651     1651           
  Lines       58116    58122    +6     
  Branches     5976     5979    +3     
=======================================
+ Hits        48017    48024    +7     
+ Misses      10099    10098    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@undsoft undsoft merged commit 3ada073 into master Dec 9, 2024
9 checks passed
@undsoft undsoft deleted the NAS-132909 branch December 9, 2024 11:51
@bugclerk
Copy link
Contributor

bugclerk commented Dec 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants