Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132927 / 25.04 / Adapt to changes in cloudsync.credentials API #11154

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Dec 6, 2024

Testing:

Check cloud credential form in various places.

@undsoft undsoft requested a review from a team as a code owner December 6, 2024 15:46
@undsoft undsoft requested review from bvasilenko and removed request for a team December 6, 2024 15:46
@bugclerk bugclerk changed the title NAS-132927: Adapt to changes in cloudsync.credentials API NAS-132927 / 25.04 / Adapt to changes in cloudsync.credentials API Dec 6, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 6, 2024

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (3408719) to head (5dd714d).
Report is 5 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...p/cloud-backup-form/cloud-backup-form.component.ts 0.00% 3 Missing ⚠️
...oudsync/cloudsync-form/cloudsync-form.component.ts 50.00% 3 Missing ⚠️
...tials-select/cloud-credentials-select.component.ts 66.66% 1 Missing ⚠️
...what-and-when/cloudsync-what-and-when.component.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11154      +/-   ##
==========================================
- Coverage   82.62%   82.62%   -0.01%     
==========================================
  Files        1651     1651              
  Lines       58116    58123       +7     
  Branches     5976     5977       +1     
==========================================
+ Hits        48017    48022       +5     
- Misses      10099    10101       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@undsoft undsoft merged commit c06f5c3 into master Dec 11, 2024
9 checks passed
@undsoft undsoft deleted the NAS-132927 branch December 11, 2024 08:34
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants