Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132928 / 25.04 / rsync task: mode == MODULE, ssh_credentials == null #11156

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Code review & passed tests are enough.

@AlexKarpov98 AlexKarpov98 self-assigned this Dec 9, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner December 9, 2024 09:46
@AlexKarpov98 AlexKarpov98 requested review from denysbutenko and removed request for a team December 9, 2024 09:46
@bugclerk bugclerk changed the title NAS-132928: rsync task: mode == MODULE, ssh_credentials == null NAS-132928 / 25.04 / rsync task: mode == MODULE, ssh_credentials == null Dec 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 9, 2024

Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (869a0cf) to head (f1c9e78).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11156      +/-   ##
==========================================
- Coverage   82.63%   82.62%   -0.01%     
==========================================
  Files        1651     1651              
  Lines       58160    58160              
  Branches     5986     5986              
==========================================
- Hits        48059    48056       -3     
- Misses      10101    10104       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 merged commit a155cc0 into master Dec 9, 2024
9 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-132928 branch December 9, 2024 13:51
@bugclerk
Copy link
Contributor

bugclerk commented Dec 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants