Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132873 / 25.04 / Fix styles for instance list header #11157

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

denysbutenko
Copy link
Member

Changes:

Original issue is not reproducible. Fixed instance list header position.

Testing:

Create enough instances. Check header position.

@denysbutenko denysbutenko requested a review from a team as a code owner December 9, 2024 11:34
@denysbutenko denysbutenko requested review from AlexKarpov98 and removed request for a team December 9, 2024 11:34
@bugclerk
Copy link
Contributor

bugclerk commented Dec 9, 2024

@bugclerk bugclerk changed the title NAS-132873: Fix styles for instance list header NAS-132873 / 25.04 / Fix styles for instance list header Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (869a0cf) to head (6e71916).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11157      +/-   ##
==========================================
- Coverage   82.63%   82.62%   -0.01%     
==========================================
  Files        1651     1651              
  Lines       58160    58160              
  Branches     5986     5986              
==========================================
- Hits        48059    48056       -3     
- Misses      10101    10104       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me :)

Screen.Recording.2024-12-10.at.16.14.46.mov

@denysbutenko denysbutenko merged commit a78dd27 into master Dec 10, 2024
9 checks passed
@denysbutenko denysbutenko deleted the NAS-132873 branch December 10, 2024 16:04
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants